Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bat-native-ledger DEPS reference to be 0.58.x #988

Merged
merged 1 commit into from Nov 29, 2018
Merged

Update bat-native-ledger DEPS reference to be 0.58.x #988

merged 1 commit into from Nov 29, 2018

Conversation

@bsclifton
Copy link
Member

bsclifton commented Nov 29, 2018 •
edited

Fixes brave/brave-browser#2298

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@bsclifton
Update bat-native-ledger DEPS reference to be 0.58.x
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
Loading status checks…
005b47e 
Fixes brave/brave-browser#2298
@bsclifton bsclifton self-assigned this Nov 29, 2018
@bsclifton bsclifton requested a review from jasonrsadler Nov 29, 2018
@bsclifton bsclifton mentioned this pull request Nov 29, 2018
Merged
10 of 18 tasks complete
@jasonrsadler
jasonrsadler approved these changes Nov 29, 2018
View changes
Copy link
Contributor

jasonrsadler left a comment

++
@bsclifton bsclifton merged commit f2e60e0 into master Nov 29, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jasonrsadler jasonrsadler deleted the bsc-fix-ledger-deps branch Nov 29, 2018
bsclifton added a commit that referenced this pull request Nov 29, 2018
@bsclifton
Merge pull request #988 from brave/bsc-fix-ledger-deps
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
Loading status checks…
0e1c7b6 
Update bat-native-ledger DEPS reference to be 0.58.x
@bsclifton
Copy link
Member Author

bsclifton commented Nov 29, 2018

master f2e60e0
0.59.x 0e1c7b6
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrsadler jasonrsadler

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
  0.59.x - Release
Linked issues

Successfully merging this pull request may close these issues.

Fix bat-native-ledger DEPS for master / 0.59.x
3 participants
@bsclifton @jasonrsadler @bbondy
You can’t perform that action at this time.