Brave iOS Browser
Clone or download
Permalink
Type Name Latest commit message Commit time
Failed to load latest commit information.
Account Fix #81: Enable Device Code Signing (#47) Jul 11, 2018
BraveShareTo Fix #243: Added translations from some translated languages (#559) Dec 4, 2018
BraveShared No Bug: Added Fresh translations (#581) Dec 5, 2018
BraveSharedTests Fix #432: Match DAU behavior to Android. (#444) Dec 4, 2018
Client.xcodeproj Fix #564: Use local adblock.dat for stats counting. (#573) Dec 5, 2018
Client Fix #593: Bookmark order migration (#602) Dec 7, 2018
ClientTests Fix #422: malware/phishing protection. (#436) Nov 28, 2018
Data Fix #593: Bookmark order migration (#602) Dec 7, 2018
DataTests Revert to using `order` for Bookmarks/Favorites. (#600) Dec 7, 2018
Docs Bug 1455013 - Wikipedia is broken in Reader Mode (#3836) Apr 19, 2018
Extensions Fix #288: Remove the Today extension Sep 28, 2018
L10nSnapshotTests Fix #72: Remove reader list and relevant tests Jul 18, 2018
MarketingUITests No Bug - Update version to 12.0. Apr 27, 2018
Providers Fix #167: Add search engine preference migration Nov 8, 2018
Push Remove Account, Sync, SyncTelemetry, and FxA frameworks (#49) Jun 12, 2018
PushTests Remove Account, Sync, SyncTelemetry, and FxA frameworks (#49) Jun 12, 2018
Shared Fix #471: Migrate per-domain shield overrides (#583) Dec 5, 2018
SharedTests Fix #471: Migrate per-domain shield overrides (#583) Dec 5, 2018
Storage Fix #243: Added translations from some translated languages (#559) Dec 4, 2018
StoragePerfTests No Bug - Update version to 12.0. Apr 27, 2018
StorageTests Fix unit tests affected by swiftlint fixes Sep 25, 2018
Sync Fix #81: Enable Device Code Signing (#47) Jul 11, 2018
SyncTelemetry Fix #81: Enable Device Code Signing (#47) Jul 11, 2018
ThirdParty Remove intro screen and LeanPlum tracking library (#44) Jun 8, 2018
UITests Switch from loading images by name to image literals Aug 31, 2018
XCUITests Fix #111: Remove Firefox Sync, Tests, and Related Strings Jul 24, 2018
fastlane Fix #371: Add release fastlane that sets the URP API key (#435) Dec 5, 2018
l10n Fix #244, Fix #247: Localize cleanup (#400) Nov 16, 2018
test-fixtures Bug 1446492 - XCUITest that loads more than 1000 bookmarks (#3805) Apr 4, 2018
.gitattributes No Bug - Exclude Thirdparty files from github language stats. (#2132) Sep 29, 2016
.gitignore Fix #564: Use local adblock.dat for stats counting. (#573) Dec 5, 2018
.swiftlint.yml Fix all warnings caused by the `force_cast` rule Sep 25, 2018
.travis.yml Fix Travis CI Integration (#395) Nov 12, 2018
AUTHORS Update AUTHORS Mar 22, 2017
Cartfile Fix build issues related to Carthage + CI (#392) Nov 12, 2018
Cartfile.resolved Fix build issues related to Carthage + CI (#392) Nov 12, 2018
Client-Bridging-Header.h Fix #542, add adblock lib for stats counting. Dec 5, 2018
Dangerfile No Bug - Add a few linting rules via Danger. (#3369) Oct 27, 2017
Duplicates.txt Fix #244, Fix #247: Localize cleanup (#400) Nov 16, 2018
Gemfile No Bug - Reenable swiftlint. Fix a small number of linting errors. (#… Oct 13, 2017
ISSUE_TEMPLATE.md Update issue template Jun 21, 2018
L10nSnapshotTests-Info.plist Bug 1247624 - Reset snapshot test schemes so that they run properly u… Feb 16, 2016
LICENSE Initial import Nov 4, 2014
Leanplum.json Create Leanplum.json Aug 25, 2017
MMA.md Bug 1409886 - Add a LeanPlum event for when a user clicks on a Pocket… Oct 23, 2017
PULL_REQUEST_TEMPLATE Revert "Updated PR template." -prematurely added this commit Sep 6, 2018
README.md Update README(iOS 12 version support) Nov 15, 2018
bootstrap.sh Ref #555, remove remove regional adblock filters count. Dec 5, 2018
codecov.yml Bug 1411757 - Eliminate codecov failures (#3383) Oct 27, 2017
get_adblock_regions.cpp Fix #542, add adblock lib for stats counting. Dec 5, 2018
l10n-screenshots.sh Bug 1406515 — L10n screenshots for Photon, & ScreenGraph Evolution. (… Nov 8, 2017
package-lock.json Fix #542, add adblock lib for stats counting. Dec 5, 2018
package.json Fix #542, add adblock lib for stats counting. Dec 5, 2018
setup_build_tools.sh Fix #112: Updated UI labels throughout to use 'Brave'. Jul 17, 2018
shipping_locales.txt Bug 1445749 - Set up the list of locales shipping for v11 Mar 14, 2018
swiftlint.sh Add SwiftLint as a build phase and report results to Xcode's editor Sep 24, 2018
update_search_engines.sh Added script to update search engines Aug 3, 2018
webpack.config.js Bug 1435239 - Favicons not showing on the TabTray (#3625) Feb 5, 2018

README.md

Brave for iOS 🦁

Download on the App Store.

This branch (development)

This branch is for mainline development that will ship in the next release.

This branch currently supports iOS 12, and is written in Swift 4.

Please make sure you aim your pull requests in the right direction.

For bug fixes and features for the upcoming release, please see the associated GitHub milestones (e.g. 2.1.3).

Getting involved

We encourage you to participate in this open source project. We love Pull Requests, Bug Reports, ideas, (security) code reviews or any kind of positive contribution.

Want to contribute but don't know where to start? Here is a list of Good First Issues.

Building the code

  1. Install the latest Xcode developer tools from Apple. (Xcode 10 and up required)
  2. Install Carthage:
    brew update
    brew install carthage
  3. Install SwiftLint:
    brew install swiftlint
  4. Clone the repository:
    git clone https://github.com/brave/brave-ios.git
  5. Pull in the project dependencies:
    cd brave-ios
    sh ./bootstrap.sh
  6. Open Client.xcodeproj in Xcode.
  7. Build the Fennec scheme in Xcode.

Contributor guidelines

Creating a pull request

  • All pull requests must be associated with a specific GitHub issue.
  • If a bug corresponding to the fix does not yet exist, please file it.
  • Please use the following formats in your PR titles:
      Fix/Ref #<issueId>: <description>.
      Examples:
      Fix #102: Added Face ID usage description to plist.
      Ref #102: Fixed type on Face ID usage description.
  • Add any additional information regarding the PR in the description.
  • In the unlikely and rare situation that a PR fixing multiple, related issues separate issue numbers with a comma:
      Fix #159, Fix #160: Removed whitepsace for + button on right-side panel.
  • PRs will be squashed and merged, so it is important to keep PRs focused on specific tasks.

Swift style

Whitespace

  • New code should not contain any trailing whitespace.
  • We recommend enabling the "Automatically trim trailing whitespace" and keeping "Including whitespace-only lines" deselected in Xcode (under Text Editing).

Commits

  • Each commit should have a single clear purpose. If a commit contains multiple unrelated changes, those changes should be split into separate commits.
  • If a commit requires another commit to build properly, those commits should be squashed.
  • Follow-up commits for any review comments should be squashed. Do not include "Fixed PR comments", merge commits, or other "temporary" commits in pull requests.

In most cases Pull Request commits will remain intact with a merge commit on the targeted branch.

Code Signing

  1. After running the bootstrap.sh script in the setup instructions navigate to:
    Client/Configuration/Local/DevTeam.xcconfig
  2. Add your Apple Team ID in this file:
    LOCAL_DEVELOPMENT_TEAM = KL8N8XSYF4

Team IDs look identical to provisioning profile UUIDs, so make sure this is the correct one.

The entire Local directory is included in the .gitignore, so these changes are not tracked by source control. This allows code signing without making tracked changes. Updating this file will only sign the Fennec target for local builds.

Finding Team IDs

The easiest known way to find your team ID is to log into your Apple Developer account. After logging in, the team ID is currently shown at the end of the URL:
https://developer.apple.com/account/<TEAM ID>

Use this string literal in the above, DevTeam.xcconfig file to code sign