Fix #2297: Disable Bookmarklet URLRequests

Brandon-T · web-flow · commit 84a9da22c4c1 · 2020-02-01T00:50:21.000-05:00
diff --git a/Client/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift b/Client/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift
@@ -126,12 +126,8 @@ extension BrowserViewController: WKNavigationDelegate {
             return
         }
         
-        if url.isBookmarklet && navigationAction.isAllowed {
+        if url.isBookmarklet {
             decisionHandler(.cancel)
-            
-            if let code = url.bookmarkletCodeComponent {
-                webView.evaluateJavaScript(code)
-            }
             return
         }
 

Original file line number	Diff line number	Diff line change
`@@ -126,12 +126,8 @@ extension BrowserViewController: WKNavigationDelegate {`
`126`	`126`	`return`
`127`	`127`	`}`
`128`	`128`
`129`		`- if url.isBookmarklet && navigationAction.isAllowed {`
	`129`	`+ if url.isBookmarklet {`
`130`	`130`	`decisionHandler(.cancel)`
`131`		`-`
`132`		`- if let code = url.bookmarkletCodeComponent {`
`133`		`- webView.evaluateJavaScript(code)`
`134`		`- }`
`135`	`131`	`return`
`136`	`132`	`}`
`137`	`133`