Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PopoverController from rewards-ios #1125

Closed
iccub opened this issue Jun 6, 2019 · 1 comment
Closed

Update PopoverController from rewards-ios #1125

iccub opened this issue Jun 6, 2019 · 1 comment
Assignees
@iccub
Labels
QA/Yes enhancement release-notes/exclude
Milestone
1.10

Comments

@iccub
Copy link
Contributor

@iccub iccub commented Jun 6, 2019

Rewards ios repo has an updated PopoverController, copy the changes and test how it works with our current popup panels
@iccub iccub self-assigned this Jun 6, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Jun 13, 2019
@iccub
Fix brave#1125: Update PopoverController from rewards-ios.
822b3c2 
This change also required small adjustments to calculating contentSize
for Shields and Menu view controllers.
@iccub iccub added QA/Yes and removed QA/No labels Jun 13, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Jun 13, 2019
@iccub
Fix brave#1125: Update PopoverController from rewards-ios.
8ef0e8b 
This change also required small adjustments to calculating contentSize
for Shields and Menu view controllers.
iccub added a commit to iccub/brave-ios that referenced this issue Jun 13, 2019
@iccub
Fix brave#1125: Update PopoverController from rewards-ios.
99c220a 
This change also required small adjustments to calculating contentSize
for Shields and Menu view controllers.
iccub added a commit to iccub/brave-ios that referenced this issue Jun 13, 2019
@iccub
Fix brave#1125: Update PopoverController from rewards-ios.
18ec5d0 
This change also required small adjustments to calculating contentSize
for Shields and Menu view controllers.
iccub added a commit to iccub/brave-ios that referenced this issue Jun 13, 2019
@iccub
Fix brave#1125: Update PopoverController from rewards-ios.
478e5f0 
This change also required small adjustments to calculating contentSize
for Shields and Menu view controllers.
iccub added a commit to iccub/brave-ios that referenced this issue Jun 13, 2019
@iccub
Fix brave#1125: Update PopoverController from rewards-ios.
71faa0b 
This change also required small adjustments to calculating contentSize
for Shields and Menu view controllers.
@jhreis jhreis closed this in 7e9073e Jun 13, 2019
@LaurenWags
Copy link

@LaurenWags LaurenWags commented Jul 12, 2019 •
edited by kjozwiak

  • Verified passed on iPad 5th Gen (iOS 12.3.1) running 1.10 (19.07.12.14)
    • Verified menu and shields popovers display correctly.
    • Verified could close/reopen menu and shields popovers.
    • Verified able to tap on items on menu/shields.

IMG_E934331EE597-1

IMG_977359107E99-1

  • Verification PASSED on iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.16.23)
    • Verified menu and shields popovers display correctly.
    • Verified could close/reopen menu and shields popovers.
    • Verified able to tap on items on menu/shields.

IMG_9813

IMG_9812
@kjozwiak kjozwiak added this to the 1.10 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iccub iccub

Labels
QA/Yes enhancement release-notes/exclude
Projects
None yet
Milestone
  1.10
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@kjozwiak @iccub @LaurenWags
You can’t perform that action at this time.