Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips flow doesn't have smooth transition between screens #1692

Closed
srirambv opened this issue Oct 15, 2019 · 4 comments
Closed

Tips flow doesn't have smooth transition between screens #1692

srirambv opened this issue Oct 15, 2019 · 4 comments

Comments

@srirambv
Copy link
Contributor

@srirambv srirambv commented Oct 15, 2019

Description:

Tips flow doesn't have a smooth transition between screens

Steps to Reproduce

  1. Enable rewards
  2. Visit a site and tip
  3. The tips message screen doesn't have a smooth transition

Actual result:
RPReplay_Final1571171819

Expected result:
Have a smooth transition between screens

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.13

Device details:
iPhone Xr

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

cc: @jenn-rhim @jamesmudgett @kylehickinson @Brandon-T

@kylehickinson
Copy link
Contributor

@kylehickinson kylehickinson commented Oct 15, 2019

@srirambv Sorry, which part doesn't have a smooth transition? I'm not sure what you mean by the GIF

@srirambv
Copy link
Contributor Author

@srirambv srirambv commented Oct 15, 2019

@kylehickinson when you select the tip value and click on send tip, the success message screen just pops up and barely has any fade-in transition or fade-out transition. Dismisses the message instantly

@kylehickinson kylehickinson removed this from the 1.13 milestone Oct 15, 2019
@kylehickinson
Copy link
Contributor

@kylehickinson kylehickinson commented Nov 20, 2019

@srirambv There is animation, it just happens a little quicker and its happening at the same time as dismissing the tipping screen below which is probably causing some feeling of it dismissing instantly.

You can even see it in frame 88 of the gif:
66868030-8cd74200-ef6a-11e9-86f2-67f1e2703a1f-88 (dragged)

For reference, the background animation has the same speed on both presentation & dismissal. The contents (favicon, labels, etc.) have a 0.4s presentation animation and a 0.35s dismissal animation. These are fractions of a second but I think it maybe just perceived as quicker because things are going off the screen instead of coming onto them (therefore having no feedback of stopping on screen). I could slow things down a tad, but I don't see a big reason to as dismissal animation should usually be faster anyways (lets user take control quicker)

@NejcZdovc NejcZdovc added this to Icebox in Rewards Global Jan 16, 2020
@kylehickinson
Copy link
Contributor

@kylehickinson kylehickinson commented Jan 27, 2020

@srirambv Is this still a problem based on my previous comments above, or can this be closed?

@NejcZdovc NejcZdovc removed this from Icebox in Rewards Global Feb 27, 2020
@kylehickinson kylehickinson added this to New Issues in Rewards Feb 27, 2020
@kylehickinson kylehickinson removed this from New Issues in Rewards Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.