Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTips flow doesn't have smooth transition between screens #1692
Comments
|
@srirambv Sorry, which part doesn't have a smooth transition? I'm not sure what you mean by the GIF |
|
@kylehickinson when you select the tip value and click on send tip, the success message screen just pops up and barely has any fade-in transition or fade-out transition. Dismisses the message instantly |
|
@srirambv There is animation, it just happens a little quicker and its happening at the same time as dismissing the tipping screen below which is probably causing some feeling of it dismissing instantly. You can even see it in frame 88 of the gif: For reference, the background animation has the same speed on both presentation & dismissal. The contents (favicon, labels, etc.) have a 0.4s presentation animation and a 0.35s dismissal animation. These are fractions of a second but I think it maybe just perceived as quicker because things are going off the screen instead of coming onto them (therefore having no feedback of stopping on screen). I could slow things down a tad, but I don't see a big reason to as dismissal animation should usually be faster anyways (lets user take control quicker) |
|
@srirambv Is this still a problem based on my previous comments above, or can this be closed? |

Description:
Tips flow doesn't have a smooth transition between screens
Steps to Reproduce
Actual result:

Expected result:
Have a smooth transition between screens
Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy
Brave Version:
1.13
Device details:
iPhone Xr
Website problems only:
Additional Information
cc: @jenn-rhim @jamesmudgett @kylehickinson @Brandon-T