Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when enabling search suggestions #1725

Closed
anthonypkeane opened this issue Oct 17, 2019 · 1 comment
Closed

Crash when enabling search suggestions #1725

anthonypkeane opened this issue Oct 17, 2019 · 1 comment
Assignees
@kylehickinson
Labels
QA Pass - iPad QA Pass - iPhone QA Pass - iPhone X QA/Yes crash release-notes/exclude
Milestone
1.13

Comments

@anthonypkeane
Copy link
Collaborator

@anthonypkeane anthonypkeane commented Oct 17, 2019

Description:

There is a crash when enabling search suggestion

Internal Chat: https://bravesoftware.slack.com/archives/C06UXF3KJ/p1571345618120200?thread_ts=1571345550.120000&cid=C06UXF3KJ

Steps to Reproduce

  1. Turn off search suggestion
  2. Search for something
  3. Turn on search suggestion
  4. search for something and the app will crash

Actual result:

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]
easy

Brave Version:
1.13 (19.10.16.18)

Device details:
13

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@anthonypkeane anthonypkeane added this to the 1.13 milestone Oct 17, 2019
kylehickinson added a commit that referenced this issue Oct 17, 2019
@kylehickinson
Fix #1725: Update suggestions list on main thread
Loading status checks…
b900c47
@kylehickinson kylehickinson self-assigned this Oct 17, 2019
@kylehickinson kylehickinson mentioned this issue Oct 17, 2019
Closed
2 of 7 tasks complete
kylehickinson added a commit that referenced this issue Oct 17, 2019
@kylehickinson
Fix #1725: Update suggestions list on main thread
Loading status checks…
5359931
@srirambv
Copy link
Contributor

@srirambv srirambv commented Oct 18, 2019

Verification passed on iPhone Xr with iOS 13.2 running 1.13(19.10.18.15)

  • Verified turning off search suggestions and performing a search doesn't crash
  • Verified turning on search suggestions and performing a search doesn't crash

Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.10.18.15)

  • Verified turning off search suggestions and performing a search doesn't crash
  • Verified turning on search suggestions and performing a search doesn't crash

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.10.18.15)

  • Verified turning off search suggestions and performing a search doesn't crash
  • Verified turning on search suggestions and performing a search doesn't crash

Verification passed on iPhone 6 with iOS 12.4 running 1.13(19.10.18.15)

  • Verified turning off search suggestions and performing a search doesn't crash
  • Verified turning on search suggestions and performing a search doesn't crash

Verification passed on iPad Pro with iOS 12.4 running 1.13(19.10.18.15)

  • Verified turning off search suggestions and performing a search doesn't crash
  • Verified turning on search suggestions and performing a search doesn't crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
QA Pass - iPad QA Pass - iPhone QA Pass - iPhone X QA/Yes crash release-notes/exclude
Projects
None yet
Milestone
  1.13
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@kylehickinson @anthonypkeane @srirambv
You can’t perform that action at this time.