Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample ad notification for Brave Rewards appears in vertically middle rather than vertically top #1794

Closed
yachtcaptain23 opened this issue Oct 24, 2019 · 4 comments

Comments

@yachtcaptain23
Copy link

@yachtcaptain23 yachtcaptain23 commented Oct 24, 2019

Steps to Reproduce

  1. Install Brave
  2. Go through OOBE and turn on ads
  3. Default notification appears in the middle of the screen at the top of the popup panel

Actual result:
Default notification appears in the middle of the screen at the top of the popup panel

Expected result:
Appears at the top of the screen

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:
iPadOS 13.1.2

Website problems only:

  • did you check with Brave Shields down? No
  • did you check in Safari/Firefox (WkWebView-based browsers)? No

Additional Information

@Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Oct 28, 2019

Implementation:

image

Design:

image

Is it wrong or? Because I did it exactly how I was told :S

@kylehickinson
Copy link
Contributor

@kylehickinson kylehickinson commented Oct 28, 2019

I think this is expected, @karenkliu can confirm

@karenkliu
Copy link
Collaborator

@karenkliu karenkliu commented Oct 28, 2019

haha aw. Yeah, this is correct for now.

I think when we update this onboarding with iPad-specific graphics though we'll want to have an ad notification that looks more iPad native.

@kylehickinson
Copy link
Contributor

@kylehickinson kylehickinson commented Oct 29, 2019

As per Karen, going to close this for now as expected behaviour. Will revisit in a future iPad-specific onboarding updates ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.