Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab tray cells look bad in dark mode #1796

Closed
iccub opened this issue Oct 25, 2019 · 1 comment
Closed

Tab tray cells look bad in dark mode #1796

iccub opened this issue Oct 25, 2019 · 1 comment

Comments

@iccub
Copy link
Contributor

@iccub iccub commented Oct 25, 2019

Description:

Steps to Reproduce

  1. Open few tabs in dark mode

Actual result:

Zrzut ekranu 2019-10-25 o 15 34 27

Expected result:
background color should be visible

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@iccub iccub self-assigned this Oct 25, 2019
iccub added a commit that referenced this issue Oct 25, 2019
@kylehickinson kylehickinson added this to the 1.14 milestone Nov 7, 2019
@srirambv
Copy link
Contributor

@srirambv srirambv commented Nov 18, 2019

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.13.19)

  • Verified theme toggle from control center doesn't affect the tabs tiles
  • Verified setting theme to dark manually doesn't affect the tab tiles
    image

Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.13.19)

  • Verified theme toggle from control center doesn't affect the tabs tiles
  • Verified setting theme to dark manually doesn't affect the tab tiles
    image

Verification passed on iPad Pro with iOS 13.2 running 1.14(19.11.13.19)

  • Verified theme toggle from control center doesn't affect the tabs tiles
  • Verified setting theme to dark manually doesn't affect the tab tiles
    image

Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.13.19)

  • Verified setting theme to dark manually doesn't affect the tab tiles
    image

Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.13.19)

  • Verified setting theme to dark manually doesn't affect the tab tiles
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.