Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claim grant button can be spammed #1882

Closed
iccub opened this issue Nov 2, 2019 · 1 comment
Closed

Claim grant button can be spammed #1882

iccub opened this issue Nov 2, 2019 · 1 comment
Assignees
@iccub
Labels
Epic: Rewards/Ads QA/Yes bug release-notes/exclude

Comments

@iccub
Copy link
Contributor

@iccub iccub commented Nov 2, 2019

Description:

Steps to Reproduce

  1. Try to claim grant
  2. When it's loading try to tap on it few times

Actual result:
Loading spinner gets stuck, and I can see in logs that the reqest is being resent

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@iccub iccub self-assigned this Nov 2, 2019
iccub added a commit that referenced this issue Nov 2, 2019
@iccub
Fix #1882: Prevent spamming grant claim button.
Loading status checks…
32ce667
@iccub iccub mentioned this issue Nov 2, 2019
Closed
6 of 7 tasks complete
@kylehickinson
Copy link
Contributor

@kylehickinson kylehickinson commented Nov 4, 2019

Will be fixed with virtual grants PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iccub iccub

Labels
Epic: Rewards/Ads QA/Yes bug release-notes/exclude
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@kylehickinson @iccub
You can’t perform that action at this time.