Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards onboarding is behind the PB modals #1906

Closed
srirambv opened this issue Nov 6, 2019 · 1 comment
Closed

Rewards onboarding is behind the PB modals #1906

srirambv opened this issue Nov 6, 2019 · 1 comment

Comments

@srirambv
Copy link
Contributor

@srirambv srirambv commented Nov 6, 2019

Description:

Rewards onboarding is behind the PB modals

Steps to Reproduce

  1. Clean install Appstore build
  2. Go to settings and set PB only
  3. Upgrade to 1.13 and launch browser
  4. Onboarding screen is hidden behind PB modals

Actual result:
image

Expected result:
Onboarding should be shown above app modals

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.12.1->1.13

Device details:
iPhone

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@srirambv
Copy link
Contributor Author

@srirambv srirambv commented Nov 21, 2019

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.20.19)

  • Verified rewards onboarding is shown first after update
  • Skipping/enabling rewards closes onboarding and then shows PB modals

Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.20.19)

  • Verified rewards onboarding is shown first after update
  • Skipping/enabling rewards closes onboarding and then shows PB modals

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.20.19)

  • Verified rewards onboarding is shown first after update
  • Skipping/enabling rewards closes onboarding and then shows PB modals

Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.20.19)

  • Verified rewards onboarding is shown first after update
  • Skipping/enabling rewards closes onboarding and then shows PB modals

Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.20.19)

  • Verified rewards onboarding is shown first after update
  • Skipping/enabling rewards closes onboarding and then shows PB modals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.