Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInitial DAU Ping Sent without Ref Code when Not using Clipboard #2586
Comments
|
On implementation, we should only perform a DAU ping when If it is After URP server request is made (either to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Found while testing #2535
When running thru
Fallback to Standard Systemtest case from above PR, my DAU ping was sent without my promo code. Per internal discussions (https://bravesoftware.slack.com/archives/C06UXF3KJ/p1590597370287800), it seems this is likely because the ping was sent before the ref code was obtained (and thus, not shown in the logs). It's possibly a race condition not accounted for.Note - while testing other scenarios in this PR (such as
Clipboard Full Test), DAU ping was displayed in logs and did contain ref code.Steps to Reproduce
Actual result:

No ping displayed: (note - this was discussed and a ping is being sent, but because it does not contain the URP code is not shown in logs)
Expected result:

Ping:
Reproduces how often: [Easily reproduced, Intermittent Issue]
easily with this scenario
Brave Version:
1.17 (20.05.27.15)
Device details:
iPad iOS12
Website problems only:
Additional Information