Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange `firstPingSuccess` Behavior #416
Closed
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/brave/brave-ios/pull/399/files#diff-4cd4e2c0264423573c81795757e55822R88
We have some code like:
We should modify
firstPingSuccessto be more clear in its purpose. This is new for 1.7, so modifying before launch would be best.Could even name it something like
firstPingRequired, to modify the logic, as right now inverting the resultlet firstLaunch = !firstPingis a bit odd.