Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change `firstPingSuccess` Behavior #416

Closed
jhreis opened this issue Nov 16, 2018 · 0 comments
Closed

Change `firstPingSuccess` Behavior #416

jhreis opened this issue Nov 16, 2018 · 0 comments
Assignees

Comments

@jhreis
Copy link
Contributor

@jhreis jhreis commented Nov 16, 2018

https://github.com/brave/brave-ios/pull/399/files#diff-4cd4e2c0264423573c81795757e55822R88

We have some code like:

/// First ping preference is set after first successful ping to the server.
let firstPing = Preferences.DAU.firstPingSuccess.value
// First launch ping should be send only if first ping was not successful yet.
let firstLaunch = !firstPing

We should modify firstPingSuccess to be more clear in its purpose. This is new for 1.7, so modifying before launch would be best.

Could even name it something like firstPingRequired, to modify the logic, as right now inverting the result let firstLaunch = !firstPing is a bit odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.