Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset All Domain Shields on Global Toggle #420

Closed
jhreis opened this issue Nov 16, 2018 · 0 comments
Closed

Reset All Domain Shields on Global Toggle #420

jhreis opened this issue Nov 16, 2018 · 0 comments
Assignees
Labels

Comments

@jhreis
Copy link
Contributor

@jhreis jhreis commented Nov 16, 2018

When a global shield setting changes (e.g. no_script), all no_script flags on Domain need to be reset to nil. This avoids accidental white/black lists.

Example:

  • no_script is off globally
  • user visits site X, and toggles no_script on, followed by turning it back off
  • if user were to turn no_script on globally, the off value on website X would be overriding this

The other implementation option is to reset Domain shield specific settings whenever they are toggled to == global.

Example:

  • no_script is off globally
  • user visits site X, and toggles no_script on, followed by turning it back off
  • instead of storing false for X.no_script, it is switched back to nil, since it is no longer performing an override.

This is probably more efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.