Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReset All Domain Shields on Global Toggle #420
Closed
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a global shield setting changes (e.g.
no_script), allno_scriptflags onDomainneed to be reset tonil. This avoids accidental white/black lists.Example:
no_scriptisoffgloballyno_scripton, followed by turning it backoffno_scriptonglobally, theoffvalue on website X would be overriding thisThe other implementation option is to reset
Domainshield specific settings whenever they are toggled to== global.Example:
no_scriptisoffgloballyno_scripton, followed by turning it backofffalseforX.no_script, it is switched back tonil, since it is no longer performing an override.This is probably more efficient.