Migrate Script Blocking to use `javaScriptEnabled` #428

jhreis · 2018-11-20T17:08:32Z

Currently Javascript is blocked via content rules. webView.configuration.preferences contains a javaScriptEnabled flag that should be utilized.

Shield enabling should be detectable via: !domainForShields.shieldIsEnabled(.NoScript) inside of:

webView(_ webView: WKWebView, decidePolicyFor navigationAction: WKNavigationAction, decisionHandler: @escaping (WKNavigationActionPolicy)

This also requires changes to stats collection, as stats currently leverage all content rules for detection.


        Fix #428: Use `WKPreferences.javascriptEnabled` for script blocking


        Fix #428: Use `WKPreferences.javascriptEnabled` for script blocking

cndouglas mentioned this issue Nov 21, 2018

Make blocking scripts detectable, similar to Safari's behavior #429

Closed

kylehickinson self-assigned this Nov 22, 2018

kylehickinson added a commit that referenced this issue Nov 22, 2018

Fix #428: Use `WKPreferences.javascriptEnabled` for script blocking

Loading status checks…

32c1915

kylehickinson added a commit that referenced this issue Nov 27, 2018

Fix #428: Use `WKPreferences.javascriptEnabled` for script blocking

2b5882c

jhreis closed this in a980860 Nov 27, 2018

brave / brave-ios

Migrate Script Blocking to use `javaScriptEnabled` #428

Migrate Script Blocking to use `javaScriptEnabled` #428

jhreis commented Nov 20, 2018

brave / brave-ios

Join GitHub today

Migrate Script Blocking to use `javaScriptEnabled` #428

Migrate Script Blocking to use `javaScriptEnabled` #428

Comments

jhreis commented Nov 20, 2018