Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blocking scripts detectable, similar to Safari's behavior #429

Closed
iccub opened this issue Nov 20, 2018 · 4 comments
Closed

Make blocking scripts detectable, similar to Safari's behavior #429

iccub opened this issue Nov 20, 2018 · 4 comments

Comments

@iccub
Copy link
Contributor

@iccub iccub commented Nov 20, 2018

To see what I mean, disable javascript in Safari(advanced options in settings)
and look at results of google search and twitter

Brave with javascript blocked
zrzut ekranu 2018-11-20 o 22 23 47

Safari with javascript blocked
zrzut ekranu 2018-11-20 o 22 23 23

As you can see websites can see that Safari has javascript blocked and tries to server non-javascript friendly websites.

We need to research whether it is possible to do in WKWebView. Implementing this would result in better browsing experience without js enabled.

@iccub iccub added the enhancement label Nov 20, 2018
@cndouglas
Copy link
Contributor

@cndouglas cndouglas commented Nov 21, 2018

This will likely be fixed with #428.

Setting webView.configuration.preferences.javascriptEnabled = false gives the following:

@iccub
Copy link
Contributor Author

@iccub iccub commented Nov 21, 2018

@jhreis did some initial tests with javascriptEnabled and said it didn't work this way.
We plan to work on this shortly after iOS 1.7 is released, thanks for doing the research Liunkae :)

@cndouglas
Copy link
Contributor

@cndouglas cndouglas commented Dec 4, 2018

Fixed by #428. Confirmed in the current master:
image

@iccub
Copy link
Contributor Author

@iccub iccub commented Aug 12, 2019

Fixed by #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.