Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Reader mode custom fonts (Fira/New York) not being used within the reader mode page #5553

Closed
kylehickinson opened this issue Jun 20, 2022 · 1 comment · Fixed by #5554
Closed

Reader mode custom fonts (Fira/New York) not being used within the reader mode page #5553

kylehickinson opened this issue Jun 20, 2022 · 1 comment · Fixed by #5554
Assignees
@kylehickinson
Labels
bug Epic: Reader-mode QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.40

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Jun 20, 2022 •
edited

Description:

The reader mode serif and sans-serif fonts are defaulting to helvetica/times instead of the custom fonts

Actual result:

Reader mode uses Helvetica/Times New Roman

Sans-Serif Serif
IMG_E02B102D6D6C-1 IMG_96FD277F87CB-1

Expected result:

Reader mode should use Fira Sans/New York Medium

Sans-Serif Serif
Simulator Screen Shot - iPhone 13 Pro - 2022-06-20 at 12 57 59 Simulator Screen Shot - iPhone 13 Pro - 2022-06-20 at 12 58 04

Reproduces how often: Always
Brave Version: 1.39
@kylehickinson kylehickinson self-assigned this Jun 20, 2022
kylehickinson added a commit that referenced this issue Jun 20, 2022
@kylehickinson
Fix #5553: Update reader mode CSS to use correct custom fonts
6a8412f 
Also Ref #5380: Adds registering of custom fonts that don't live in the main bundle
@kylehickinson kylehickinson mentioned this issue Jun 20, 2022
Merged
7 tasks
kylehickinson added a commit that referenced this issue Jun 20, 2022
@kylehickinson
Fix #5553: Update reader mode CSS to use correct custom fonts (#5554)
2e31fd7 
Also Ref #5380: Adds registering of custom fonts that don't live in the main bundle
@kylehickinson kylehickinson added this to the 1.40 milestone Jun 20, 2022
@Uni-verse
Copy link
Contributor

Verified using 1.40 (22.6.21.16)

Test Devices:
iPhone 12 | iOS 15.4
iPhone X | iOS 14.4.2
iPad | iOS 15.5

  • Verified Reader Mode uses Fira Sans/New York Medium by default.
  • Verified Reader settings will persist when changing webpages.
Sans Serif Serif
IMG_3114 IMG_3115
IMG_0373 IMG_0374

soner-yuksel pushed a commit that referenced this issue Jun 22, 2022
@kylehickinson @soner-yuksel
Fix #5553: Update reader mode CSS to use correct custom fonts (#5554)
4bc7a7e 
Also Ref #5380: Adds registering of custom fonts that don't live in the main bundle
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Reader-mode QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.40
Development

Successfully merging a pull request may close this issue.

Fix #5553: Update reader mode CSS to use correct custom fonts brave/brave-ios
2 participants
@kylehickinson @Uni-verse