Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login to Facebook keeps redirecting #558

Closed
srirambv opened this issue Dec 4, 2018 · 6 comments
Closed

Login to Facebook keeps redirecting #558

srirambv opened this issue Dec 4, 2018 · 6 comments

Comments

@srirambv
Copy link
Contributor

@srirambv srirambv commented Dec 4, 2018

Description:

Login to Facebook keeps redirecting

Steps to Reproduce

  1. Install 1.7 (18.12.3.22)
  2. Open https://m.facebook.com/
  3. Enter credentials and click login
  4. Throw phone in anger as it doesn't allow you to login and instead keeps trying to redirect

Actual result:
Need to practice zen to keep self calm

Expected result:
Waste time scrolling through FB feed

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.7 (18.12.3.22)

Device details:
All

Website problems only:

  • did you check with Brave Shields down?
    Yes, still doesn't work chances of breaking iPhone is more
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Issue reproduced by @GeetaSarvadnya

@srirambv
Copy link
Contributor Author

@srirambv srirambv commented Dec 4, 2018

This only happens when you upgrade from 1.7 (18.11.30.03). On clean install of 1.7(18.12.3.22) it logs in but you can only see the page when shields is down. Shields up just keeps a blank page.

@jhreis
Copy link
Contributor

@jhreis jhreis commented Dec 4, 2018

Probably something with content rules.
Probably not content rules actually, if shields don't impact it.

@iccub
Copy link
Contributor

@iccub iccub commented Dec 4, 2018

This does not happen to me when going 1.6->1.7.
Could we revisit this ticket once QA will test 1.6 upgrades?

@srirambv
Copy link
Contributor Author

@srirambv srirambv commented Dec 4, 2018

@iccub all issues with QA/Yes will be rechecked once the migration build is available.

@jhreis
Copy link
Contributor

@jhreis jhreis commented Dec 5, 2018

This should be fixed now due to adblock file upgrade. @srirambv can you please retest?

@srirambv
Copy link
Contributor Author

@srirambv srirambv commented Dec 5, 2018

Checked on migration as well. Login works fine. Page doesn't keep redirecting like before. Closing as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.