Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private tabs is lost during migration update when app is in background #568

Closed
srirambv opened this issue Dec 5, 2018 · 1 comment
Closed
Labels

Comments

@srirambv
Copy link
Contributor

@srirambv srirambv commented Dec 5, 2018

Description:

Private tabs is lost during migration update when app is in background

Steps to Reproduce

  1. Set 1.6.6 to be on normal tabs
  2. Open a couple of private tabs and visit sites in them
  3. Background the app and upgrade to 1.7
  4. After upgrade launch, pin is enabled(#566) and private tabs opened are lost, focus is set to first normal tab

Actual result:
Private tabs is lost during migration update when app is in background

Expected result:
Should retain the private tabs that were active when app was still in memory

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.7 (18.12.04.23)

Device details:
iPhone and iPad

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@jhreis
Copy link
Contributor

@jhreis jhreis commented Dec 5, 2018

This is expected behavior. This is basically a desktop browser upgrade, where it has to quit the app to upgrade. Since we don't save private browsing data, these cannot be recovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.