Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content blocker compile checks to fastlane test lane #656

Closed
kylehickinson opened this issue Dec 18, 2018 · 1 comment
Closed

Add content blocker compile checks to fastlane test lane #656

kylehickinson opened this issue Dec 18, 2018 · 1 comment
Labels
QA/No enhancement release-notes/exclude

Comments

@kylehickinson
Copy link
Contributor

@kylehickinson kylehickinson commented Dec 18, 2018

Use does-it-compile.swift to determine if all lists shipped in the app compile
kylehickinson added a commit that referenced this issue Jan 10, 2019
@kylehickinson
Fix #656: Add content blocker compile checks to fastlane test lane
Loading status checks…
e8833ad
kylehickinson added a commit that referenced this issue Feb 7, 2019
@kylehickinson
Fix #656: Add content blocker compile checks to fastlane test lane
Loading status checks…
e8314a2
@iccub
Copy link
Contributor

@iccub iccub commented Aug 12, 2019

Seems to be fixed by e8314a2

Please note that regional lists are not checked by it because they are not bundled, they are downloaded at app launch
@iccub iccub closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA/No enhancement release-notes/exclude
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@kylehickinson @jhreis @iccub
You can’t perform that action at this time.