Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPSE upgrade count not shown on shields #691

Closed
srirambv opened this issue Jan 10, 2019 · 4 comments
Closed

HTTPSE upgrade count not shown on shields #691

srirambv opened this issue Jan 10, 2019 · 4 comments
Assignees
@kylehickinson
Labels
QA/Yes bug

Comments

@srirambv
Copy link
Contributor

@srirambv srirambv commented Jan 10, 2019

Description:

HTTPSE upgrade count not shown on shields

Steps to Reproduce

1.Visit https://https-everywhere.badssl.com/
2. Open shields
3. HTTPS shows count as 0

Actual result:
file 1

Expected result:
Shields should show count 1 for HTTPSE

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.7.3 (19.1.09.19)

Device details:
All

Website problems only:

  • did you check with Brave Shields down?
    N/A
  • did you check in Safari/Firefox (WkWebView-based browsers)?
    N/A

Additional Information
@srirambv
Copy link
Contributor Author

@srirambv srirambv commented Jan 11, 2019

The stats for HTTPSE on new tab also remains 0.
@kylehickinson
Copy link
Contributor

@kylehickinson kylehickinson commented Jan 11, 2019 •
edited

The stats will not increase if you're visiting an already upgraded website (STR step 1 says visit https://https-everywhere.badssl.com)

I reproduced visiting http variant as well, fixing
@kylehickinson kylehickinson self-assigned this Jan 11, 2019
kylehickinson added a commit that referenced this issue Jan 11, 2019
@kylehickinson
Fix #691: Fix HTTPSE stats not increasing for non-redirecting upgrades
Loading status checks…
8381d12 
HTTPS upgrade content blocker just causes most websites to request http but respond with https, therefore not making a second provisional navigation to https.
This altered solution works with both cases
@srirambv
Copy link
Contributor Author

@srirambv srirambv commented Jan 11, 2019

@kylehickinson Not really. Its supposed to update. This is the behaviour on desktop
https
@kylehickinson
Copy link
Contributor

@kylehickinson kylehickinson commented Jan 11, 2019

Desktop only seems to do that the first time you visit the website and only when you are scheme-less. If I load badssl.com it increase the stat, if I load https://badssl.com it doesn't.
@jhreis jhreis closed this in c31510a Jan 14, 2019
@srirambv srirambv mentioned this issue Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
QA/Yes bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@kylehickinson @srirambv
You can’t perform that action at this time.