Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync order is not updating after reordering bookmarks. #772

Closed
iccub opened this issue Jan 21, 2019 · 7 comments
Closed

Sync order is not updating after reordering bookmarks. #772

iccub opened this issue Jan 21, 2019 · 7 comments

Comments

@iccub
Copy link
Contributor

@iccub iccub commented Jan 21, 2019

More actions will be done after a server side bug brave/sync#231 is fixed

For now when you reorder a bookmark on one device it does not get updated on other devices, tested on iOS-iOS so far.

@anthonypkeane
Copy link
Collaborator

@anthonypkeane anthonypkeane commented Jan 23, 2019

@iccub

Do you only find this when moving bookmarks under the same folder, or do you find it all the time?

@iccub
Copy link
Contributor Author

@iccub iccub commented Jan 23, 2019

On iOS, only moving bookmarks under the same folder is supported.
So it happens every time I try to move a bookmark

@anthonypkeane
Copy link
Collaborator

@anthonypkeane anthonypkeane commented Jan 24, 2019

cc @darkdh

@srirambv srirambv added the sync label Feb 6, 2019
@srirambv
Copy link
Contributor

@srirambv srirambv commented Feb 6, 2019

There is a weird bug here when bookmarks/folders are reordered on one device
Device 1: iPhone 7+ sync chain creator with existing bookmarks
Device 2: iPad Pro created empty bookmark folder post sync
Reorder all bookmark folders to the end post sync causes the following

Device 1:
image from ios
Device 2:
file 5

Closing the bookmark tray and reopening it shows correctly. Also some times it messes up the ordering and folders start showing up with weird colours

@iccub
Copy link
Contributor Author

@iccub iccub commented Feb 6, 2019

Could you make a separate issue for it @srirambv?

@iccub
Copy link
Contributor Author

@iccub iccub commented Feb 6, 2019

Update on this issue:
it was caused by a client side bug, I have a fix for it ready

@srirambv
Copy link
Contributor

@srirambv srirambv commented Mar 18, 2019

  • Verification passed on iPhone 6/7+ and iPad Pro running 1.9(19.3.9.1)
  • Verified passed with 1.9 (19.3.9.1) on iPhone SE
  • Verification PASSED with 1.9 (19.03.25.21) on iPad Mini 4 using the above STR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.