Add localized strings

BraveShared/BraveStrings.swift

@@ -26,6 +26,8 @@ public extension Strings {
     public static let CopyLinkActionTitle = NSLocalizedString("CopyLinkActionTitle", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Copy Link", comment: "Context menu item for copying a link URL to the clipboard")
     public static let OpenNewPrivateTabButtonTitle = NSLocalizedString("OpenNewPrivateTabButtonTitle", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Open in New Private Tab", comment: "Context menu option for opening a link in a new private tab")
     public static let DeleteLoginButtonTitle = NSLocalizedString("DeleteLoginButtonTitle", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Delete", comment: "Label for the button used to delete the current login.")
+    static let SaveButtonTitle = NSLocalizedString("SaveButtonTitle", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Save", comment: "Label for the button used to save data")
+
 }
 
 // MARK:-  UIAlertControllerExtensions.swift
@@ -485,4 +487,14 @@ public extension Strings {
     public static let DDG_callout_no = NSLocalizedString("DDGCalloutNo", tableName: "BraveShared", bundle: Bundle.braveShared, value: "No", comment: "DuckDuckGo callout no action.")
     public static let DDG_callout_enable = NSLocalizedString("DDGCalloutEnable", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Yes", comment: "DuckDuckGo callout enable action.")
     public static let DDG_promotion = NSLocalizedString("LearnAboutPrivateSearchrwithDuckDuckGo", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Learn about private search \nwith DuckDuckGo", comment: "DuckDuckGo promotion label.")
+    static let NewFolderDefaultName = NSLocalizedString("NewFolderDefaultName", tableName: "BraveShared", bundle: Bundle.braveShared, value: "New Folder", comment: "Default name for creating a new folder.")
+    static let NewBookmarkDefaultName = NSLocalizedString("NewBookmarkDefaultName", tableName: "BraveShared", bundle: Bundle.braveShared, value: "New Bookmark", comment: "Default name for creating a new bookmark.")
+    static let BookmarkTitlePlaceholderText = NSLocalizedString("BookmarkTitlePlaceholderText", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Name", comment: "Placeholder text for adding or editing a bookmark")
+    static let BookmarkUrlPlaceholderText = NSLocalizedString("BookmarkUrlPlaceholderText", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Address", comment: "Placeholder text for adding or editing a bookmark")
+    static let FavoritesLocationFooterText = NSLocalizedString("FavoritesLocationFooterText", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Favorites are located on your home screen. These bookmarks are not synchronized with other devices.", comment: "Footer text when user selects to save to favorites when editing a bookmark")
+    static let BookmarkRootLevelCellTitle = NSLocalizedString("BookmarkRootLevelCellTitle", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Bookmarks", comment: "Title for root level bookmarks cell")
+    static let FavoritesRootLevelCellTitle = NSLocalizedString("FavoritesRootLevelCellTitle", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Favorites", comment: "Title for favorites cell")
+    static let AddFolderActionCellTitle = NSLocalizedString("AddFolderActionCellTitle", tableName: "BraveShared", bundle: Bundle.braveShared, value: "New folder", comment: "Cell title for add folder action")
+    static let EditBookmarkTableLocationHeader = NSLocalizedString("EditBookmarkTableLocationHeader", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Location", comment: "Header title for bookmark save location")
+
 }

Client/Frontend/Browser/Toolbars/BottomToolbar/Menu/AddEditBookmarkTableViewController.swift

@@ -5,6 +5,7 @@
 import UIKit
 import CoreData
 import Data
+import Shared
 
 protocol AddEditBookmarkDelegate: class {
     func didSelectFolder(/*_ folder: Bookmark*/)
@@ -86,7 +87,7 @@ class AddEditBookmarkTableViewController: UITableViewController {
         let button = UIBarButtonItem()
         button.target = self
         button.action = #selector(save)
-        button.title = "Save"
+        button.title = Strings.SaveButtonTitle
 
         return button
     }()
@@ -271,8 +272,15 @@ class AddEditBookmarkTableViewController: UITableViewController {
         }
     }
 
+    override func tableView(_ tableView: UITableView, titleForFooterInSection section: Int) -> String? {
+        switch location {
+        case .favorites: return Strings.FavoritesLocationFooterText
+        default: return nil
+        }
+    }
+
     override func tableView(_ tableView: UITableView, titleForHeaderInSection section: Int) -> String? {
-        return "Location"
+        return Strings.EditBookmarkTableLocationHeader
     }
 
     override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
@@ -298,14 +306,14 @@ class AddEditBookmarkTableViewController: UITableViewController {
     }
 
     func showNewFolderVC() {
-        let vc = AddEditBookmarkTableViewController(mode: .newFolder(title: "New folder"))
+        let vc = AddEditBookmarkTableViewController(mode: .newFolder(title: Strings.NewFolderDefaultName))
         vc.delegate = self
         navigationController?.pushViewController(vc, animated: true)
     }
 
     var rootLevelFolderCell: IndentedImageTableViewCell {
         let cell = IndentedImageTableViewCell().then {
-            $0.folderName.text = "Bookmarks"
+            $0.folderName.text = Strings.BookmarkRootLevelCellTitle
             $0.tag = Location.rootLevelTag
             if case .rootLevel = location, presentationMode == .folderHierarchy {
                 $0.accessoryType = .checkmark
@@ -317,7 +325,7 @@ class AddEditBookmarkTableViewController: UITableViewController {
 
     var favoritesCell: IndentedImageTableViewCell {
         let cell = IndentedImageTableViewCell(image: #imageLiteral(resourceName: "menu-Bookmark"))
-        cell.folderName.text = "Favorites"
+        cell.folderName.text = Strings.FavoritesRootLevelCellTitle
         cell.tag = Location.favoritesTag
         if case .favorites = location, presentationMode == .folderHierarchy {
             cell.accessoryType = .checkmark
@@ -350,7 +358,7 @@ class AddEditBookmarkTableViewController: UITableViewController {
             case .newBookmark(_), .editBookmark(_):
                 if row == 0 {
                     let cell = IndentedImageTableViewCell(image: #imageLiteral(resourceName: "add_tab"))
-                    cell.folderName.text = "New Folder"
+                    cell.folderName.text = Strings.AddFolderActionCellTitle
                     cell.accessoryType = .disclosureIndicator
                     cell.tag = Location.newFolderTag
 

Client/Frontend/Browser/Toolbars/BottomToolbar/Menu/BookmarkDetailsView.swift

@@ -4,6 +4,7 @@
 
 import UIKit
 import SnapKit
+import Shared
 
 protocol BookmarkDetailsViewDelegate: class {
     func correctValues(validationPassed: Bool)
@@ -91,8 +92,8 @@ class BookmarkDetailsView: UIView, BookmarkFormFieldsProtocol {
             faviconImageView.setIcon(nil, forURL: favUrl)
         }
 
-        titleTextField.text = title ?? "New bookmark"
-        urlTextField.text = url ?? "New folder"
+        titleTextField.text = title ?? Strings.NewBookmarkDefaultName
+        urlTextField.text = url ?? Strings.NewFolderDefaultName
 
         mainStackView.snp.makeConstraints {
             $0.edges.equalTo(self)

Client/Frontend/Browser/Toolbars/BottomToolbar/Menu/FolderDetailsView.swift

@@ -3,6 +3,7 @@
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import UIKit
+import Shared
 
 class FolderDetailsViewTableViewCell: UIView, BookmarkFormFieldsProtocol {
 
@@ -41,7 +42,7 @@ class FolderDetailsViewTableViewCell: UIView, BookmarkFormFieldsProtocol {
         mainStackView.addArrangedSubview(titleTextField)
         mainStackView.addArrangedSubview(spacerLine)
 
-        titleTextField.text = title ?? "New folder"
+        titleTextField.text = title ?? Strings.NewFolderDefaultName
 
         mainStackView.snp.makeConstraints {
             $0.edges.equalTo(self)