Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1102 by changing the WKWebview privacy protection using tab's isPrivate value. #1103

Merged
merged 2 commits into from Jul 10, 2019
+18 −78
Merged

Fixed #1102 by changing the WKWebview privacy protection using tab's isPrivate value. #1103

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2635cd6
Added logic to utilise tab's `isPrivate` state to appropriately initi…
danishjafri88 May 21, 2019
7c8b7f5
Removed PrivacyProtectionProtocol and refactored code with Bool.
danishjafri88 Jun 21, 2019
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Added logic to utilise tab's `isPrivate` state to appropriately initi… 

…alise the WKWebview.
  • Loading branch information
@danishjafri88
danishjafri88 committed May 21, 2019
commit 2635cd6fd1ae2e886e2de32fc6ae0d73aaf8768d
4 Client/Frontend/Browser/PrivacyProtection/PrivacyProtection.swift
View file
Open in desktop
@@ -8,8 +8,6 @@ import UIKit
final class PrivacyProtection: PrivacyProtectionProtocol {

var nonPersistent: Bool {
let isPrivateBrowsing = PrivateBrowsingManager.shared.isPrivateBrowsing
return isPrivateBrowsing
return true

This comment has been minimized.

Sign in to view
Copy link
@iccub

iccub May 22, 2019

Contributor

Can simplify this to let nonPersistent = true if we are never changing it

This comment has been minimized.

Sign in to view
Copy link
@jhreis

jhreis Jun 21, 2019

Contributor

Can we actually just completely remove PrivacyProtectionProtocol? The only difference between the two is a true/false boolean. Can't we just put a flag nonPersistent directly onto the webview rather than using a protocol and two custom classes?
}

}
3 Client/Frontend/Browser/Tab.swift
View file
Open in desktop
@@ -191,7 +191,8 @@ class Tab: NSObject {
configuration!.allowsInlineMediaPlayback = true
// Enables Zoom in website by ignoring their javascript based viewport Scale limits.
configuration!.ignoresViewportScaleLimits = true
let webView = TabWebView(frame: .zero, configuration: configuration!)
let protectionLevel: PrivacyProtectionProtocol = isPrivate ? PrivacyProtection() : NoPrivacyProtection()
let webView = TabWebView(frame: .zero, configuration: configuration!, privacyProtection: protectionLevel)
webView.delegate = self
configuration = nil

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.