Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression #1228 Added updated jp translation with placeholder #1238

Merged
merged 1 commit into from Jul 12, 2019
Merged

Regression #1228 Added updated jp translation with placeholder #1238

merged 1 commit into from Jul 12, 2019

Conversation

@danishjafri88
Copy link
Contributor

danishjafri88 commented Jul 11, 2019 •
edited by iccub

Pulled a pending translation wrt #1228

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • My patch or PR title has a standard commit message that looks like Fix #123: This fixes the shattered coffee cup! (or No Bug: <message> if no relevant ticket)
  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New files have MPL-2.0 license header.

Test Plan:

Screenshots:

Reviewer Checklist:

  • PR is linked to an issue via Zenhub.
  • Issues are assigned to at least one epic.
  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable)
@danishjafri88
Added updated jp translation with placeholder
Loading status checks…
1445095
@danishjafri88 danishjafri88 requested a review from iccub Jul 11, 2019
@iccub
iccub approved these changes Jul 12, 2019
View changes
@iccub iccub merged commit 85a08fd into development Jul 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@iccub iccub deleted the translation.missing branch Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccub iccub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@danishjafri88 @iccub
You can’t perform that action at this time.