Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1298: Text input support on AlertPopupView #1341
Merged
Conversation
|
Few code style comments |
| @@ -48,6 +52,22 @@ class AlertPopupView: PopupView { | |||
| messageLabel.numberOfLines = 0 | |||
| containerView.addSubview(messageLabel) | |||
|
|
|||
| if let inputType = inputType { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| fileprivate var dialogImage: UIImageView? | ||
| fileprivate var titleLabel: UILabel! | ||
| fileprivate var messageLabel: UILabel! | ||
| fileprivate var containerView: UIView! | ||
| fileprivate var textField: UITextField? | ||
|
|
||
| public var text: String? { |
This comment has been minimized.
This comment has been minimized.
package-lock.json
Outdated
| @@ -104,10 +104,22 @@ | |||
| "version": "github:brave/ad-block#b933cf5168c5284dc159735d8bcefb415d0cfc00", | |||
| "from": "github:brave/ad-block#b933cf5168c5284dc159735d8bcefb415d0cfc00", | |||
| "requires": { | |||
| "bloom-filter-cpp": "^1.2.2", | |||
| "bloom-filter-cpp": "^1.2.0", | |||
This comment has been minimized.
This comment has been minimized.
iccub
Aug 7, 2019
Contributor
It would be best to not version this package-lock.json file at all for this PR
|
lgtm. @jamesmudgett in future please make sure to complete the PR template submitter checklist. @iccub feel free to merge if you approve it, please just verify the squashed message, as it may not be correct by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jamesmudgett commentedAug 7, 2019
•
edited by iccub
Adds text input support for AlertPopupView. Supports all input(keyboard) types and secure input as well. Example usage:
Submitter Checklist:
Fix #123: This fixes the shattered coffee cup!(orNo Bug: <message>if no relevant ticket)NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement