Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCustom client for ddg. #1479
Merged
Custom client for ddg. #1479
Conversation
|
I think some of the behaviors here aren't quite right, but that is mostly due to product requirements not being clear. I'm blocking this for now, and bumping the ticket out of the current milestone. |
|
Will leave more formal review once we identify the exact, expected behavior. |
|
This should be ready for review @jhreis |
Client/Application/AppDelegate.swift
Outdated
| @@ -273,6 +272,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UIViewControllerRestorati | |||
| } | |||
|
|
|||
| AdblockResourceDownloader.shared.startLoading() | |||
| Preferences.General.isFirstLaunch.value = false | |||
This comment has been minimized.
This comment has been minimized.
jhreis
Sep 27, 2019
Contributor
I don't think we should move this, if we ran into some weird issue, it could end up duplicating all default favorites. I think that is the only real thing that uses the isFirstLaunch bool.
8bbc364
to
fa4f693
|
Very nice! |
|
lgtm |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
iccub commentedSep 3, 2019
•
edited by jhreis
Ref: internal#648
Summary of Changes
This pull request fixes issue #1478
Submitter Checklist:
NSLocalizableString()Test Plan:
Verify iOS device is in the United States region
Launch Brave and use DDG as the default search engine (can go into private mode to make this easier)
Perform a search
Verify the URL contains
t=bravein the URL bar (may need to long-press "copy" and paste somewhere else to see full URL)Change iOS device region to New Zealand
Back in Brave perform another DDG search
verify URL contains
t=braveed(noticed additionaled)That's it. Cheers🌮
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement