Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1470: Use SQS for Sync device fetch. #1569
Merged
Conversation
|
The PR is ready for review. I'm blocking it until we ship 1.12, sync testing takes a lot of QA team time |
|
Merging this now to get it into development for whenever the next beta goes live. But please add a test plan @iccub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
iccub commentedSep 20, 2019
•
edited
Summary of Changes
This pull request fixes issue #1470
Submitter Checklist:
NSLocalizableString()Test Plan:
Pair two devices, verify they are showing at settings screen.
Sync is a bit buggy as you know, so if any problems happen, please compare it with earlier versions to see if this PR has introduced any regressions.
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement