Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRef #1376: Regression with creating store and old location on 1st launch #1586
Conversation
| @@ -41,18 +40,6 @@ public class DataController: NSObject { | |||
| return mom | |||
| }() | |||
|
|
|||
| // Internal scope so unit tests can recreate the DB stack as needed. | |||
| override init() { | |||
This comment has been minimized.
This comment has been minimized.
iccub
Sep 27, 2019
Author
Contributor
This initalizer was called before migration was fully completed, and on first launch it was using the old documents directory. After removing it all should be working fine.
This was done to fix intermittent bug with data tests, but so far these tests are not failing, I will keep an eye on it
| managedObjectModel: DataController.model) | ||
|
|
||
| super.init() | ||
| storeSetup() |
This comment has been minimized.
This comment has been minimized.
danishjafri88
Sep 27, 2019
Contributor
This function storeSetup . is only used here. We can remove it. perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
iccub commentedSep 27, 2019
•
edited by jhreis
Summary of Changes
This pull request fixes issue #1376
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement