Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1593: Unneeded file cleanup/XCode cleanup #1589

Merged
merged 35 commits into from Sep 30, 2019
Merged

Conversation

@iccub
Copy link
Contributor

iccub commented Sep 27, 2019

Summary of Changes

This pull request fixes issue #1593

Since the code changes is too big, please look at commit names to see what things have been deleted or changed.

Overall summary of changes:

What was deleted:

  • UI tests
  • Push
  • Snapshot
  • FF marketing tests
  • Buddybuild SDK, was still bundled in the app
  • Unused 3rd party code
  • old extensions files and its entitlements
  • FF’s settings bundle
  • Account scheme
  • FF’s CI files: danger, code coverage tool

Folder/Group fixes
Certain folders were not linked in XCode and were still set as groups.
Also some files were placed in wrong location but still linked to folders
For example TabEventHandlers.swift was sitting in Client folder, but in XCode it was showing in Client/Helpers.
For such cases I moved the files accordingly

The only group type of folders left are Config, Frameworks and Products

New Config group.
It contains npm, carthage and other config files for quick access in xcode.
These files were but moved but only added as references.

Zrzut ekranu 2019-09-30 o 15 25 53

Please squash all commits when merging, if something is wrong with this PR it will be easier to revert all changes at once

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
iccub added 30 commits Sep 27, 2019
FF files, we do not use them.
These are FF files not used by us.
This does not move files only adds references in XCode.
All configs are now in root directory's `config` group.
@iccub iccub marked this pull request as ready for review Sep 30, 2019
@iccub iccub requested a review from jhreis Sep 30, 2019
@iccub iccub changed the title Nobug/file cleanup Fix #1593: Unneeded file cleanup/XCode cleanup Sep 30, 2019
@jhreis
Copy link
Contributor

jhreis commented Sep 30, 2019

Couple questions:

  1. Does this make it any more complicated for us in the future to enable UITests if we want, or is this solely the removal of the literal FF UITests?
  2. Do we want to implement codecov? Maybe something we can discuss at a later point, so removal of the file is probably not an issue.
@iccub
Copy link
Contributor Author

iccub commented Sep 30, 2019

  1. This is removal of UI tests and their framework for UI tests based on ScreenGraph
    FYI the screengraph ui test stuff is now a separate framework https://github.com/mozilla-mobile/MappaMundi and if we would like to go this route it's better to use this newer approach

  2. I would add it later, we have some ideas for CI improvements, like blocking merging if WIP string is presented

@iccub iccub merged commit d4526ca into development Sep 30, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@iccub iccub deleted the nobug/file_cleanup branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.