Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1593: Unneeded file cleanup/XCode cleanup #1589
Merged
Conversation
FF files, we do not use them.
These are FF files not used by us.
It was not used
This does not move files only adds references in XCode.
All configs are now in root directory's `config` group.
|
Couple questions:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
iccub commentedSep 27, 2019
•
edited
Summary of Changes
This pull request fixes issue #1593
Since the code changes is too big, please look at commit names to see what things have been deleted or changed.
Overall summary of changes:
What was deleted:
Folder/Group fixes
Certain folders were not linked in XCode and were still set as
groups.Also some files were placed in wrong location but still linked to folders
For example
TabEventHandlers.swiftwas sitting inClientfolder, but in XCode it was showing inClient/Helpers.For such cases I moved the files accordingly
The only
grouptype of folders left areConfig,FrameworksandProductsNew
Configgroup.It contains npm, carthage and other config files for quick access in xcode.
These files were but moved but only added as references.
Please squash all commits when merging, if something is wrong with this PR it will be easier to revert all changes at once
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement