Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1602: Update private alert action text #1605

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@dangdennis
Copy link
Contributor

dangdennis commented Oct 5, 2019

Summary of Changes

This pull request fixes issue #1602

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@iccub
iccub approved these changes Oct 7, 2019
Copy link
Contributor

iccub left a comment

Thanks for your first contribution :)

Would you mind posting a screenshot of the text change?

@dangdennis
Copy link
Contributor Author

dangdennis commented Oct 7, 2019

I found a UI regression actually. Will fix this as well. You should change it back to RFC 😄
Screen Shot 2019-10-07 at 10 55 04 AM
Screen Shot 2019-10-07 at 10 56 33 AM

@dangdennis
Copy link
Contributor Author

dangdennis commented Oct 7, 2019

Fixed! I can see this section of the code being refactored to better handle state between private and non-private mode.

Screen Shot 2019-10-07 at 11 12 21 AM

@iccub iccub merged commit f7a6bce into brave:development Oct 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.