Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1631: Give Rewards notifications a clear background #1632

Merged
merged 1 commit into from Oct 11, 2019
Merged

Fix #1631: Give Rewards notifications a clear background #1632

merged 1 commit into from Oct 11, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 11, 2019 •
edited by jhreis

Summary of Changes

This pull request fixes issue #1631

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson
Fix #1631: Give Rewards notifications a clear background
Loading status checks…
d5744cf
@kylehickinson kylehickinson requested a review from iccub Oct 11, 2019
@iccub
iccub approved these changes Oct 11, 2019
View changes
@jhreis jhreis modified the milestone: 1.13 Oct 11, 2019
@jhreis jhreis merged commit fe7a86a into development Oct 11, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jhreis jhreis deleted the rewards-notification-bg-color branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccub iccub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kylehickinson @iccub @jhreis
You can’t perform that action at this time.