Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Onboarding SafeAreaInsets: Fixes #1649 #1684

Merged
merged 3 commits into from Oct 15, 2019
Merged

Conversation

@Brandon-T
Copy link
Collaborator

Brandon-T commented Oct 15, 2019

  • Extends the onboarding into the safe-area insets and fixes the animation to match.
  • Verified Lottie Animations are 100% updated at this moment in time.. We might still get "new" ones for the publisher-icon not being round.. but that's out of the scope of this ticket.

Summary of Changes

This pull request fixes issue #1649

Simulator Screen Shot - iPhone 11 - 2019-10-15 at 13 00 10
Simulator Screen Shot - iPhone 11 - 2019-10-15 at 13 00 14
Simulator Screen Shot - iPhone 11 - 2019-10-15 at 13 00 19

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@Brandon-T Brandon-T requested review from iccub and kylehickinson Oct 15, 2019
@iccub
iccub approved these changes Oct 15, 2019
Copy link
Contributor

iccub left a comment

Looks good, please add a screenshot of the fixed view

@iccub iccub mentioned this pull request Oct 15, 2019
0 of 7 tasks complete
@Brandon-T Brandon-T force-pushed the feature/Onboarding_Fixes branch from f4e36f8 to 271e82a Oct 15, 2019
@Brandon-T Brandon-T force-pushed the feature/Onboarding_Fixes branch from 271e82a to d4b4529 Oct 15, 2019
@Brandon-T Brandon-T force-pushed the feature/Onboarding_Fixes branch from d4b4529 to 6d88bdb Oct 15, 2019
@iccub iccub merged commit 559098d into development Oct 15, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@iccub iccub deleted the feature/Onboarding_Fixes branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.