Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1683: Update verified/unverified publisher icons #1690

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 15, 2019

Summary of Changes

This pull request fixes issue #1683

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Enable rewards
  • Visit a unverified publisher, verify round grey icon
  • Visit a verified publisher (i.e. bumpsmack.com), verify rounded icon in both panel + URL bar

Screenshots:

Unverified Verified
Simulator Screen Shot - iPhone 11 Pro - 2019-10-15 at 15 30 20 Simulator Screen Shot - iPhone 11 Pro - 2019-10-15 at 15 30 09

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson kylehickinson requested a review from iccub Oct 15, 2019
@Brandon-T
Copy link
Collaborator

Brandon-T commented Oct 15, 2019

For the publisher icon (IE: The "reddit" icon in the OP), is it supposed to have a circle around it?

@kylehickinson
Copy link
Contributor Author

kylehickinson commented Oct 15, 2019

Not sure what you mean by "have a circle around it".

@Brandon-T
Copy link
Collaborator

Brandon-T commented Oct 15, 2019

@kylehickinson

iOS:
Screen Shot 2019-10-15 at 4 19 34 PM

Android:
Screen Shot 2019-10-15 at 4 19 28 PM

@kylehickinson
Copy link
Contributor Author

kylehickinson commented Oct 15, 2019

Ahh, yes it is supposed to be circled, based on designs I made the UI from. Not sure why Android's isn't

@kylehickinson kylehickinson merged commit 28d1f25 into development Oct 15, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the verified-icon-updates branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.