Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1698: Update Japanese translations for Rewards. #1699
Merged
Conversation
| @@ -844,9 +844,6 @@ | |||
| /* Add a Computer title */ | |||
| "SyncAddComputerTitle" = "Einen Computer hinzufügen"; | |||
|
|
|||
| /* Add mobile device to sync with scan */ | |||
| "SyncAddDeviceScan" = "QR-Code der Kette scannen"; | |||
This comment has been minimized.
This comment has been minimized.
iccub
Oct 16, 2019
Author
Contributor
Note: these two removed strings have updated recently and haven't been re-translated yet.
They will be re-added later after new translations are in
iccub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
iccub commentedOct 16, 2019
•
edited
Summary of Changes
This pull request fixes issue #1698
Submitter Checklist:
NSLocalizableString()Test Plan:
Set device's region and language to Japanese, test out Rewards UI
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement