Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1689: Display the correct BAT value for one-time-tips #1701

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 16, 2019

Also fixes the duplication of "USD" in the tips list

Summary of Changes

This pull request fixes issue #1689

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Enable rewards
  • Add a recurring tip for a publisher
  • Add a one time tip for a publisher
  • Verify in the rewards settings → tips details that the list displays all BAT values as regular decimals amounts (i.e. "1.0 BAT")
  • Verify that USD is not repeated

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
Also fixes the duplication of "USD" in the tips list
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 16, 2019
@iccub
iccub approved these changes Oct 16, 2019
@kylehickinson kylehickinson merged commit 0a173c3 into development Oct 16, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the probi-tips branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.