Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1696: Make "My First Ad" use a shorter dismissal duration #1703

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 16, 2019

Also ignores the debug override

Summary of Changes

This pull request fixes issue #1696

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Enable rewards
  • Install fresh build
  • Go through onboarding, at my first ad, verify it disappears in 3s instead of 8s
  • Verify a regular ad stays up for 8s (or whatever amount is set in the debug menu)

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
Also ignores the debug override
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 16, 2019
@kylehickinson kylehickinson merged commit 6d86c03 into development Oct 16, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the my-first-ad-duration branch Oct 16, 2019
@kylehickinson kylehickinson mentioned this pull request Oct 23, 2019
7 of 7 tasks complete
@srirambv
Copy link
Contributor

srirambv commented Nov 1, 2019

@kylehickinson is this still valid for actual ad? With #1773 ad time is increased to 30 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.