Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1706, Fix #1711: Copy fixes #1716

Merged
merged 1 commit into from Oct 17, 2019
Merged

Fix #1706, Fix #1711: Copy fixes #1716

merged 1 commit into from Oct 17, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 17, 2019 •
edited by iccub

Brave Verified Publisher -> Brave Verified Creator
Minimum Length -> Minimum Page Time

@iccub This will require updates to the JP localization I assume?

Summary of Changes

This pull request fixes issue #1706
This pull request fixes issue #1711

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • View verified publisher, verify it says "Brave Verified Creator" instead
  • View minimum page length time setting screen from Brave Rewards settings AC screen, verify it says Minimum Page Time in title

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson
Fix #1706, Fix #1711: Copy fixes
Loading status checks…
0b8bba4 
`Brave Verified Publisher` -> `Brave Verified Creator`
`Minimum Length` -> `Minimum Page Time`
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 17, 2019
@iccub
Copy link
Contributor

iccub commented Oct 17, 2019

Yes it will, I would say we should update translations after all text related tickets are fixed
@iccub
iccub approved these changes Oct 17, 2019
View changes
Copy link
Contributor

iccub left a comment

As Kyle mentioned, we need push to transifex and pull updates
@kylehickinson kylehickinson merged commit 19a32a5 into development Oct 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the copy-changes branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccub iccub

@Brandon-T Brandon-T

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@kylehickinson @iccub
You can’t perform that action at this time.