Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1705: Fix incorrect title when changing monthly AC payment value #1717

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 17, 2019

Summary of Changes

This pull request fixes issue #1705

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • View the monthly payment setting screen in Auto Contribute settings, verify title is not recurring tips
  • Setup a recurring tip on a user, verify when trying to edit said tip amount from the main wallet panel that it's title is "recurring tip" still

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 17, 2019
@iccub
iccub approved these changes Oct 17, 2019
@kylehickinson kylehickinson merged commit 4ee02e6 into development Oct 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the wrong-title branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.