Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1708: Update Rewards Panel Icon to have more contrast in dark mode #1723

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 17, 2019

Summary of Changes

This pull request fixes issue #1708

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Enable Rewards
  • Go into dark mode
  • Visit a verified publisher, icon should be easier to see (white checkmark)

Screenshots:

Simulator Screen Shot - iPhone 11 Pro - 2019-10-17 at 14 43 19

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 17, 2019
@iccub
Copy link
Contributor

iccub commented Oct 17, 2019

Does it look good in light mode on iOS 12 too?

@kylehickinson
Copy link
Contributor Author

kylehickinson commented Oct 17, 2019

Yep!

Simulator Screen Shot - iPhone Xs - 2019-10-17 at 15 32 10

@Brandon-T
Copy link
Collaborator

Brandon-T commented Oct 17, 2019

Hmm.. I was looking for the code where this gets dynamically updated when you switch modes but couldn't find it.

@kylehickinson
Copy link
Contributor Author

kylehickinson commented Oct 17, 2019

@Brandon-T It doesn't get updated based on light/dark mode. We are just using the one that has a white checkmark regardless

@kylehickinson kylehickinson merged commit 1174e77 into development Oct 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the rewards-icon-contrast branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.