Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1708: Update Rewards Panel Icon to have more contrast in dark mode #1723
Conversation
|
Does it look good in light mode on iOS 12 too? |
|
Hmm.. I was looking for the code where this gets dynamically updated when you switch modes but couldn't find it. |
|
@Brandon-T It doesn't get updated based on light/dark mode. We are just using the one that has a white checkmark regardless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.

kylehickinson commentedOct 17, 2019
Summary of Changes
This pull request fixes issue #1708
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement