Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1725: Force URLSession's to use main thread for completion block #1729

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@Brandon-T
Copy link
Collaborator

Brandon-T commented Oct 17, 2019

Force the sessions to be on the main queue. This is what Alamofire does automatically.

Summary of Changes

This pull request fixes issue #

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@Brandon-T Brandon-T requested review from kylehickinson and iccub Oct 17, 2019
@kylehickinson kylehickinson changed the title Force the sessions to be on the main queue. This is what Alamofire does automatically. Fix #1725: Force URLSession's to use main thread for completion block Oct 17, 2019
@iccub
iccub approved these changes Oct 17, 2019
@kylehickinson kylehickinson merged commit 08907f9 into development Oct 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the feature/SessionFixes branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.