Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1707: Configure popover on iPad for restoring excluded publishers #1733

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 18, 2019

Summary of Changes

This pull request fixes issue #1707

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Enable rewards, create a wallet
  • Stay on a site long enough for and navigate away to add it to the AC table
  • Open AC table (rewards settings > AC details). Swipe to exclude the entry
  • Tap restore 1 excluded site and verify that it doesn't crash

Screenshots:

Simulator Screen Shot - iPad Pro (9 7-inch) - 2019-10-18 at 11 01 10

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 18, 2019
@kylehickinson
Copy link
Contributor Author

kylehickinson commented Oct 18, 2019

Possible other solutions:

  • Overriding the trait collection on the panel to force it to be compact-width. This would then display the alert as usual as an action sheet
  • On iPad, removing the prompt
  • On both, removing the prompt
@kylehickinson kylehickinson merged commit 9f4be84 into development Oct 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the ipad-restore-crash-fix branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.