Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1525: Themable 'find in page' bar. #1743

Merged
merged 1 commit into from Oct 22, 2019
Merged

Fix #1525: Themable 'find in page' bar. #1743

merged 1 commit into from Oct 22, 2019
+23 −4

Conversation

@iccub
Copy link
Contributor

iccub commented Oct 21, 2019 •
edited

Summary of Changes

This pull request fixes issue #1525

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Zrzut ekranu 2019-10-21 o 16 54 04

Zrzut ekranu 2019-10-21 o 16 51 52

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@iccub
Fix #1525: Themable 'find in page' bar.
Loading status checks…
3e1373c
@iccub iccub requested review from Brandon-T and jhreis Oct 21, 2019
@kylehickinson
kylehickinson approved these changes Oct 21, 2019
View changes
@Brandon-T
Brandon-T approved these changes Oct 22, 2019
View changes
@kylehickinson kylehickinson merged commit fff6314 into development Oct 22, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the bugfix/1525 branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson

@Brandon-T Brandon-T

@jhreis jhreis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@iccub @kylehickinson @Brandon-T
You can’t perform that action at this time.