Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1651: Update Rewards UI based on if region is set to JP #1755
Conversation
- "BAT" becomes "BAT Points" in most scenarios - An additional disclaimer message is shown in the rewards summary (when non-empty) - Powered by Uphold message is not shown in wallet details screen
| $0.edges.equalTo(self).inset(8) | ||
| } | ||
|
|
||
| backgroundColor = UIColor(white: 0.0, alpha: 0.04) |
This comment has been minimized.
This comment has been minimized.
iccub
Oct 22, 2019
Contributor
Could you check if this looks good on iOS 12 with light and dark theme?
If not we would need to change this to appearanceBackgroundColor I believe
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
iccub
Oct 22, 2019
Contributor
no, leave it as it is, we do not use this property in specific classes only in appearance proxies from what I see, theming is gonna drag us down a bit until we drop iOS 12 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.

kylehickinson commentedOct 22, 2019
•
edited by iccub
Summary of Changes
This pull request fixes issue #1651
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement