Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1745: Update ads design to better match system notifications #1756

Merged
merged 1 commit into from Oct 22, 2019
Merged

Fix #1745: Update ads design to better match system notifications #1756

merged 1 commit into from Oct 22, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 22, 2019 •
edited by iccub

Summary of Changes

This pull request fixes issue #1745

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Screenshots:

Light Dark
Simulator Screen Shot - iPhone 11 Pro - 2019-10-22 at 11 52 02 Simulator Screen Shot - iPhone 11 Pro - 2019-10-22 at 11 53 47

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson
Fix #1745: Update ads design to better match system notifications
Loading status checks…
d789b76
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 22, 2019
@iccub
iccub approved these changes Oct 22, 2019
View changes
@iccub iccub requested a review from jamesmudgett Oct 22, 2019
@jamesmudgett
jamesmudgett approved these changes Oct 22, 2019
View changes
Copy link
Contributor

jamesmudgett left a comment

Looks great
@kylehickinson kylehickinson merged commit 853c3a1 into development Oct 22, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the notifications-design-fixes branch Oct 22, 2019
@srirambv srirambv mentioned this pull request Oct 30, 2019
Closed
@bradleyrichter
Copy link

bradleyrichter commented Oct 30, 2019

looks good to me as well...

cc @anthonypkeane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmudgett jamesmudgett

@iccub iccub

@Brandon-T Brandon-T

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@kylehickinson @bradleyrichter @jamesmudgett @iccub
You can’t perform that action at this time.