Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1757: Show rewards onboarding to existing users when not in an ad-supported region #1758
+1
−1
Conversation
… agreement..
c5cc4d0
to
e79812a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Brandon-T commentedOct 22, 2019
•
edited by kylehickinson
When the user is OUT of ads region, and existing user, we can show rewards agreement.. There is no way for me to tell if rewards are available though :S
Which means, if the user is new, they complete onboarding up to shields. After some time, they upgrade or kill the app, now they are existing, and rewards show up which didn't show up previously.
Summary of Changes
This pull request fixes issue #1757
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement