Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1757: Show rewards onboarding to existing users when not in an ad-supported region #1758

Merged

Conversation

@Brandon-T
Copy link
Collaborator

Brandon-T commented Oct 22, 2019

When the user is OUT of ads region, and existing user, we can show rewards agreement.. There is no way for me to tell if rewards are available though :S

Which means, if the user is new, they complete onboarding up to shields. After some time, they upgrade or kill the app, now they are existing, and rewards show up which didn't show up previously.

Summary of Changes

This pull request fixes issue #1757

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@Brandon-T Brandon-T requested review from jhreis, kylehickinson and iccub Oct 22, 2019
@kylehickinson kylehickinson changed the title When the user is OUT of ads region, and existing, we can show rewards Fix #1757: Show rewards onboarding to existing users when not in an ad-supported region Oct 22, 2019
@Brandon-T Brandon-T force-pushed the feature/OnboardingOutOfAdsRegionExistingUser branch from c5cc4d0 to e79812a Oct 22, 2019
@kylehickinson kylehickinson merged commit a05e57e into development Oct 22, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the feature/OnboardingOutOfAdsRegionExistingUser branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.