Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1765, Fix #1744: Adds missing JP rewards UI updates #1766
Conversation
| @@ -53,7 +53,7 @@ extension OnboardingRewardsViewController { | |||
| private let titleLabel = CommonViews.primaryText(Strings.OBRewardsTitle) | |||
|
|
|||
| private let descriptionLabel = CommonViews.secondaryText("").then { | |||
| $0.attributedText = BraveAds.isCurrentRegionSupported() ? Strings.OBRewardsDetailInAdRegion.boldWords(with: $0.font, amount: 2) : Strings.OBRewardsDetailOutsideAdRegion.boldWords(with: $0.font, amount: 1) | |||
| $0.attributedText = BraveAds.isCurrentRegionSupported() ? (Locale.current.isJapan ? Strings.OBRewardsDetailInAdRegionJapan : Strings.OBRewardsDetailInAdRegion).boldWords(with: $0.font, amount: 2) : Strings.OBRewardsDetailOutsideAdRegion.boldWords(with: $0.font, amount: 1) | |||
This comment has been minimized.
This comment has been minimized.
kylehickinson
changed the title
|
A few more strings were added, please don't merge until after |
- "Grants" -> "Details" on wallet header - "Your wallet" -> "Your balance" in wallet header - "wallet balance" -> "balance" in tipping view - "tokens" -> "points" - "BAT" -> "BAT Points" where missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kylehickinson commentedOct 22, 2019
•
edited
Summary of Changes
This pull request fixes issue #1765
This pull request fixes issue #1744
Submitter Checklist:
NSLocalizableString()Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement