Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1773: Make ad auto-dismissal time 30 seconds #1779

Merged
merged 2 commits into from Oct 23, 2019
Merged

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 23, 2019

Please use rebase merge strategy

Summary of Changes

This pull request fixes issue #1773
This pull request reverts #1703

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Go through onboarding, verify my first ad remains on screen for 30s before timing out
  • With ads enabled, browse and when an ad comes up, verify it remains on screen for 30s before timing out

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 23, 2019
@iccub
iccub approved these changes Oct 23, 2019
@kylehickinson kylehickinson merged commit 7411503 into development Oct 23, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the ad-hanging branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.