Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1590: Update licenses file. Add licenses setting option. #1780
Conversation
| <input id="ac-11" name="accordion-1" type="checkbox" /> | ||
| <label for="ac-11"><h2>Alamofire</h2></label> | ||
| <input id="ac-Deferred" name="accordion-1" type="checkbox" /> | ||
| <label for="ac-Deferred"><h2>Deferred</h2></label> |
This comment has been minimized.
This comment has been minimized.
|
Hmm it flickers a little when I expand the cells and they have a weird padding but I think this is just due to HTML being rendered instead of native. Also, if the cell is at the bottom of the screen and I expand, it doesn't push up atm. I guess we can fix this later. For now, code is good. |
|
Blocking until @jhreis review and/or sec review |
|
@Brandon-T yeah, I didn't change the html implementation from what we had from upstream |
|
This looks programmatically good to me. I am waiting on some final wording, so not merging right now. update: received confirmation that this is gtg for now (see #1780 (comment) for more info) |
|
We very likely will improve upon this in the future (e.g. better text information, tag linking), but this meets what we need so merging this. |
iccub commentedOct 23, 2019
•
edited by jhreis
Summary of Changes
This pull request fixes issue #1590
Submitter Checklist:
NSLocalizableString()Test Plan:
Open Settings -> About -> Licenses. Confirm it contains MPL license and licenses of dependencies
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement