Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1783: Show verified badge for connected publishers in AC/Tips table #1784

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 24, 2019

Summary of Changes

This pull request fixes issue #1783

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Visit connected (but not verified) publisher (e.g. KhanAcademy)
  • After 8s, visit another page, then open panel
  • Verify wallet panel has verified badge but also sees the disclaimer
  • Open AC table list, verify that badge is displayed there as well
  • Tip one-time/recurring for same connected publisher
  • Open Tips list, verify that badge is displayed there as well

Screenshots:

Simulator Screen Shot - iPhone 11 Pro - 2019-10-24 at 10 29 27

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 24, 2019
@iccub
iccub approved these changes Oct 24, 2019
@kylehickinson kylehickinson merged commit 62fa961 into development Oct 24, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the connected-badge-ac-table branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.