Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1786: Don't use probi value for USD conversion on one-time tips #1785

Merged
merged 1 commit into from Oct 24, 2019
Merged

Fix #1786: Don't use probi value for USD conversion on one-time tips #1785

merged 1 commit into from Oct 24, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 24, 2019 •
edited by srirambv

Summary of Changes

This pull request fixes issue #1786 and #1689 (again)

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 24, 2019
@iccub
iccub approved these changes Oct 24, 2019
View changes
@kylehickinson
Fix #1786: Don't use probi value for USD conversion on one-time tips
Loading status checks…
79eda0d
@kylehickinson kylehickinson force-pushed the whoops-usd-tip-probi branch from c3ee534 to 79eda0d Oct 24, 2019
@kylehickinson kylehickinson changed the title Fix #1689: Don't use probi value for USD conversion on one-time tips Fix #1786: Don't use probi value for USD conversion on one-time tips Oct 24, 2019
@kylehickinson kylehickinson merged commit c7df900 into development Oct 24, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the whoops-usd-tip-probi branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccub iccub

@Brandon-T Brandon-T

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@kylehickinson @iccub
You can’t perform that action at this time.